-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Fynk components #19393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fynk components #19393
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified. |
|
Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:
|
|
Warning Rate limit exceeded@sergio-eliot-rodriguez has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 38 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughAdds four new Fynk action modules, enriches the Fynk app with dynamic propDefinitions and an HTTP client exposing list/create/update/move methods, and bumps the component package version while adding a platform dependency. Changes
Sequence Diagram(s)sequenceDiagram
participant Action as Action Module
participant App as Fynk App Client
participant Auth as Auth Store
participant API as Fynk HTTP API
Action->>App: call method (e.g., createDocumentFromTemplate / moveDocumentToSigning / updateDocumentParty) with props
App->>Auth: read this.$auth.api_token
App->>App: _getHeaders() build headers (Authorization, Accept, Content-Type)
App->>API: _makeRequest(path, method, data/params, headers)
API-->>App: response (200/201)
App-->>Action: return API response
Action->>Action: $.export("$summary", ...)
Action-->>Caller: return response
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (6)
components/fynk/actions/create-contract-from-template/create-contract-from-template.mjs(1 hunks)components/fynk/actions/move-contract-stage/move-contract-stage.mjs(1 hunks)components/fynk/actions/update-contract-metadata/update-contract-metadata.mjs(1 hunks)components/fynk/actions/update-contract-party/update-contract-party.mjs(1 hunks)components/fynk/fynk.app.mjs(1 hunks)components/fynk/package.json(2 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2024-12-12T19:23:09.039Z
Learnt from: jcortes
Repo: PipedreamHQ/pipedream PR: 14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.
Applied to files:
components/fynk/package.json
📚 Learning: 2025-09-15T22:01:11.472Z
Learnt from: GTFalcao
Repo: PipedreamHQ/pipedream PR: 18362
File: components/leonardo_ai/actions/generate-image/generate-image.mjs:103-105
Timestamp: 2025-09-15T22:01:11.472Z
Learning: In Pipedream components, pipedream/platform's axios implementation automatically excludes undefined values from HTTP requests, so there's no need to manually check for truthiness before including properties in request payloads.
Applied to files:
components/fynk/fynk.app.mjs
🧬 Code graph analysis (4)
components/fynk/actions/update-contract-metadata/update-contract-metadata.mjs (3)
components/fynk/actions/create-contract-from-template/create-contract-from-template.mjs (1)
response(48-51)components/fynk/actions/move-contract-stage/move-contract-stage.mjs (1)
response(70-70)components/fynk/actions/update-contract-party/update-contract-party.mjs (1)
response(81-86)
components/fynk/actions/create-contract-from-template/create-contract-from-template.mjs (3)
components/fynk/actions/move-contract-stage/move-contract-stage.mjs (2)
data(77-81)response(70-70)components/fynk/actions/update-contract-party/update-contract-party.mjs (2)
data(73-79)response(81-86)components/fynk/actions/update-contract-metadata/update-contract-metadata.mjs (1)
response(44-51)
components/fynk/fynk.app.mjs (4)
components/fynk/actions/create-contract-from-template/create-contract-from-template.mjs (1)
data(42-46)components/fynk/actions/move-contract-stage/move-contract-stage.mjs (1)
data(77-81)components/fynk/actions/update-contract-party/update-contract-party.mjs (1)
data(73-79)components/whatsapp_business/actions/send-text-using-template/send-text-using-template.mjs (1)
template(42-44)
components/fynk/actions/move-contract-stage/move-contract-stage.mjs (3)
components/fynk/actions/create-contract-from-template/create-contract-from-template.mjs (2)
response(48-51)data(42-46)components/fynk/actions/update-contract-metadata/update-contract-metadata.mjs (1)
response(44-51)components/fynk/actions/update-contract-party/update-contract-party.mjs (2)
response(81-86)data(73-79)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
- GitHub Check: pnpm publish
- GitHub Check: Lint Code Base
🔇 Additional comments (3)
components/fynk/actions/create-contract-from-template/create-contract-from-template.mjs (1)
1-56: Create-from-template action matches documented endpoint; minor UX clarificationProps map cleanly to the API (
template_uuid, optionalname, optionalowner_emails) and the call intocreateDocumentFromTemplateuses the correct path forPOST /documents/create-from-template. (help.fynk.com) The success summary reading fromresponse.data.name/.uuidis also consistent with the documented document resource.You might just clarify in the
ownerEmailsdescription that it expects a list (array) of email strings, not a comma‑separated string, to avoid confusion in the UI.components/fynk/actions/update-contract-party/update-contract-party.mjs (1)
1-91: Party update action cleanly maps props to API payloadThe dependent
documentUuid→partyUuidselection is wired correctly, and the payload maps 1:1 to the expected fields forPUT /documents/{document}/parties/{party}(entity_type,entity_name,address, plus optionalreferenceandscope). (help.fynk.com) The summary message gives a clear audit trail including both party and contract UUIDs. The note in theentityNamedescription about needing a non‑null value to reach the signing stage is a helpful hint; no further changes needed from my side here.components/fynk/package.json (1)
3-17: Version bump and platform dependency look consistent
0.1.0aligns with the new Fynk actions, and adding@pipedream/platformmatches the axios usage infynk.app.mjs. Confirm that the^3.1.0version range matches other components in the repo for consistency.
components/fynk/actions/update-contract-metadata/update-contract-metadata.mjs
Show resolved
Hide resolved
GTFalcao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I made minor suggestions on some prop descriptions
components/fynk/actions/move-contract-stage/move-contract-stage.mjs
Outdated
Show resolved
Hide resolved
components/fynk/actions/create-contract-from-template/create-contract-from-template.mjs
Outdated
Show resolved
Hide resolved
components/fynk/actions/update-contract-metadata/update-contract-metadata.mjs
Outdated
Show resolved
Hide resolved
components/fynk/actions/update-contract-metadata/update-contract-metadata.mjs
Show resolved
Hide resolved
components/fynk/actions/update-contract-party/update-contract-party.mjs
Outdated
Show resolved
Hide resolved
…ontract-from-template.mjs Improved component description. Co-authored-by: michelle0927 <michelle0927@users.noreply.github.com>
…ct-metadata.mjs Improved component description Co-authored-by: michelle0927 <michelle0927@users.noreply.github.com>
…e.mjs Improved component description Co-authored-by: Guilherme Falcão <48412907+GTFalcao@users.noreply.github.com>
…party.mjs Improved component descriptions Co-authored-by: michelle0927 <michelle0927@users.noreply.github.com>
michelle0927
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Moving to QA. Just remember to change the errors to ConfigurationErrors before publishing.
components/fynk/actions/move-contract-stage/move-contract-stage.mjs
Outdated
Show resolved
Hide resolved
components/fynk/actions/update-contract-metadata/update-contract-metadata.mjs
Show resolved
Hide resolved
components/fynk/actions/update-contract-metadata/update-contract-metadata.mjs
Outdated
Show resolved
Hide resolved
…e.mjs Using ConfigurationError from @pipedream/platform to handle errors Co-authored-by: michelle0927 <michelle0927@users.noreply.github.com>
…e.mjs Using ConfigurationError from @pipedream/platform to handle errors Co-authored-by: michelle0927 <michelle0927@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
components/fynk/actions/move-contract-stage/move-contract-stage.mjs(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2024-12-12T19:23:09.039Z
Learnt from: jcortes
Repo: PipedreamHQ/pipedream PR: 14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.
Applied to files:
components/fynk/actions/move-contract-stage/move-contract-stage.mjs
🧬 Code graph analysis (1)
components/fynk/actions/move-contract-stage/move-contract-stage.mjs (3)
components/fynk/actions/update-contract-party/update-contract-party.mjs (2)
response(81-86)data(73-79)components/fynk/actions/create-contract-from-template/create-contract-from-template.mjs (2)
response(48-51)data(42-46)components/fynk/actions/update-contract-metadata/update-contract-metadata.mjs (1)
response(230-237)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
- GitHub Check: Lint Code Base
🔇 Additional comments (1)
components/fynk/actions/move-contract-stage/move-contract-stage.mjs (1)
1-14: Imports and action metadata look consistent with other Fynk componentsThe import of the fynk app and
ConfigurationError, plus thekey/name/ annotations andtype: "action"all align with Pipedream’s conventions for non‑read‑only actions that mutate external state. No changes needed here.Please just double‑check that
@pipedream/platformis declared incomponents/fynk/package.jsonat the expected version so this import resolves correctly.
…ct-metadata.mjs Using ConfigurationError from @pipedream/platform when handling errors. Co-authored-by: michelle0927 <michelle0927@users.noreply.github.com>
…ct-metadata.mjs Using ConfigurationError from @pipedream/platform when handling error. Co-authored-by: michelle0927 <michelle0927@users.noreply.github.com>
I addressed hey comments about using ConfigurationError via @pipedream/platform when handling errors. After that, she said it was fine to move the PR to the "Ready for QA" status.
|
fyi @vunguyenhung this is ready for QA |
|
Hi everyone, all test cases are passed! Ready for release! Test reports
|
Resolves #19198
from the requested actions
adds
create-contract-from-template
update-contract-metadata
update-contract-party
move-contract-stage
while
upload-signed-contract remains blocked and will be moved to a separate issue.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.