Skip to content

Conversation

@ctrlaltdylan
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented May 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
pipedream-docs ✅ Ready (Inspect) Visit Preview May 4, 2022 at 2:43PM (UTC)
pipedream-docs-redirect-do-not-edit ✅ Ready (Inspect) Visit Preview May 4, 2022 at 2:43PM (UTC)

@dannyroosevelt
Copy link
Collaborator

@ctrlaltdylan I noticed a few issues w/ this documentation that should be fixed:

  • throw ConfigurationError() I think needs to be throw new ConfigurationError()
  • Looks like you have to import { ConfigurationError } from "@pipedream/platform";
  • Your code is checking to see if @ is present, then throwing the error, but I think you want the opposite, hah
  • Missing the closing })
  • The screenshot of the ConfigurationError in the UI is pretty grainy.

@ctrlaltdylan
Copy link
Contributor Author

Thanks for the double check @dannyroosevelt , I'll fix those shortly. I assumed the screenshot from the linear card would keep the same quality.

@ctrlaltdylan
Copy link
Contributor Author

@dannyroosevelt revision #2 here: #2769

1 similar comment
@ctrlaltdylan
Copy link
Contributor Author

@dannyroosevelt revision #2 here: #2769

bush4u pushed a commit that referenced this pull request May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants