Skip to content

Conversation

@GTFalcao
Copy link
Collaborator

@GTFalcao GTFalcao commented Jun 25, 2022

New Actions

  • Copy File
  • Copy Folder
  • Create Folder
  • Download Files
  • List Contents
  • Upload File

New Source

  • Watch Folder

The code used as a base pull request #1392, beginning by importing all code from Sergio's fork to this new branch.

@vercel
Copy link

vercel bot commented Jun 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
pipedream-docs ✅ Ready (Inspect) Visit Preview Jul 1, 2022 at 4:27PM (UTC)
pipedream-docs-redirect-do-not-edit ✅ Ready (Inspect) Visit Preview Jul 1, 2022 at 4:27PM (UTC)

@dylburger dylburger added the User submitted Submitted by a user label Jun 25, 2022
@dylburger
Copy link
Contributor

Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified.

@dylburger dylburger added the triaged For maintainers: This issue has been triaged by a Pipedream employee label Jun 25, 2022
@dylburger
Copy link
Contributor

Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:

@GTFalcao GTFalcao linked an issue Jun 25, 2022 that may be closed by this pull request
Copy link
Contributor

@andrewjschuang andrewjschuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GTFalcao thanks for the contribution!

Looks good but I've left a few comments below

Copy link
Contributor

@andrewjschuang andrewjschuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GTFalcao thanks for the changes!

I've made a few comments about maintaining consistent indentation for the newline separator, \\, and a few extra lines.

I also still see some return await that aren't necessary in the plcoud.app.mjs file.

};
return retry(async (bail) => {
try {
return await apiCall();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This await is actually needed since it's inside a try/catch statement

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed this - many thanks for the very complete reviews!

andrewjschuang
andrewjschuang previously approved these changes Jun 29, 2022
Copy link
Contributor

@andrewjschuang andrewjschuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! I've left one comment but moving it to QA.

@vunguyenhung
Copy link
Collaborator

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information
pCloud_3240.pdf

@vunguyenhung
Copy link
Collaborator

Hi everyone, all test cases are passed! Ready for release!

Test report
pCloud_3240_0809.pdf

@GTFalcao
Copy link
Collaborator Author

GTFalcao commented Jul 1, 2022

/approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triaged For maintainers: This issue has been triaged by a Pipedream employee User submitted Submitted by a user

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ACTION] pCloud

5 participants