-
Notifications
You must be signed in to change notification settings - Fork 5.6k
8210 playwright components #8313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
* master: Pierce/dre 452 (#8237) # Conflicts: # components/playwright/package.json # components/playwright/playwright.app.mjs # pnpm-lock.yaml
copy change
ctrlaltdylan
approved these changes
Oct 4, 2023
Contributor
ctrlaltdylan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a small change to the copy on one summary, but otherwise works well in workflows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at 6278418
This pull request updates the Playwright app and adds a new action component for it. It converts the app from TypeScript to JavaScript, fixes some code style issues, and adds new dependencies. It also deletes an unnecessary
.gitignorefile and modifies thepnpm-lock.yamlfile accordingly. The new action component returns the page's title given a URL.🤖 Generated by Copilot at 6278418
WHY
HOW
🤖 Generated by Copilot at 6278418
playwright.app.tstoplaywright.app.mjsand change the import syntax from TypeScript to JavaScript (link)pnpm-lock.yamlfile (link, link, link, link, link, link)components/playwright/.gitignorefile (link)