Skip to content

Script adjustment to ignore test event files #8366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GTFalcao merged 1 commit into from
Oct 4, 2023
Merged

Script adjustment to ignore test event files #8366

GTFalcao merged 1 commit into from
Oct 4, 2023

Conversation

@GTFalcao
Copy link
Collaborator

@GTFalcao GTFalcao commented Oct 4, 2023 •
edited by ghost
Loading

WHAT

🤖 Generated by Copilot at 354c790

Refactor code for finding bad component keys in scripts/findBadKeys.js. Simplify isTestEventFile function with includes method.

🤖 Generated by Copilot at 354c790

isTestEventFile
Simplified with includes
Code is like spring breeze

WHY

Test event files are not being properly ignored by the findBadKeys script.

HOW

🤖 Generated by Copilot at 354c790

  • Simplify isTestEventFile function to use includes method (link)

@vercel
Copy link

vercel bot commented Oct 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
pipedream-docs ✅ Ready (Inspect) Visit Preview Oct 4, 2023 8:03pm
pipedream-docs-redirect-do-not-edit ✅ Ready (Inspect) Visit Preview Oct 4, 2023 8:03pm

@GTFalcao GTFalcao mentioned this pull request Oct 4, 2023
Merged
@dylburger dylburger added the triaged For maintainers: This issue has been triaged by a Pipedream employee label Oct 4, 2023
luancazarine
luancazarine approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@luancazarine luancazarine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GTFalcao GTFalcao merged commit bf40282 into master Oct 4, 2023
@GTFalcao GTFalcao deleted the fix-bad-keys-test-event branch October 4, 2023 20:44
@GTFalcao
Copy link
Collaborator Author

GTFalcao commented Oct 4, 2023

I went ahead and merged this since the PR check runs from master, and it is a simple improvement on avoiding possible OS differences (with the forward slash '/')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luancazarine luancazarine luancazarine approved these changes

Assignees

No one assigned

Labels

triaged For maintainers: This issue has been triaged by a Pipedream employee

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GTFalcao @luancazarine @dylburger