Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Must add Edge::Position for *both* axes. #660

Closed
mitchmindtree opened this issue Jan 6, 2016 · 0 comments · Fixed by #662
Closed

Must add Edge::Position for *both* axes. #660

mitchmindtree opened this issue Jan 6, 2016 · 0 comments · Fixed by #662
Labels
bug

Comments

@mitchmindtree
Copy link
Contributor

At the moment, an Edge::Position is only added between the widget which we're relatively placed to along the X axis, even if we're also relatively positioned to a widget on the Y axis. We need to add an axis field to the Edge::Position variant - something like pub enum Axis { X, Y }.

This is currently causing buggy behaviour in scrolling.
mitchmindtree added a commit to mitchmindtree/conrod that referenced this issue Jan 8, 2016
@mitchmindtree
Update graph modules to store a Position edge for relative positionin…
e748f56 
…g on both X and Y axes. Closes PistonDevelopers#660. Also update graph modules to latest scrolling simplification changes. Simplify scroll_offset function in algo.rs. Properly consider currently updated widgets during calculation of bounding_box.
mitchmindtree added a commit to mitchmindtree/conrod that referenced this issue Jan 8, 2016
@mitchmindtree
Update widget modules to simplification of scroll module. Change scro…
edbb8c6 
…lling methods to scroll_kids for clarity of behaviour. Change pre_update_cache args to consider relative positioning across both axes in accordance with PistonDevelopers#660 changes.
@mitchmindtree mitchmindtree mentioned this issue Jan 8, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
1 participant
@mitchmindtree