Update to rusttype 0.8.3 #1411
Merged
Update to rusttype 0.8.3 #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchmindtree
force-pushed
the
rusttype-0.9.2
branch
from
5b91b8a to
12cb555
Compare
mitchmindtree
changed the title
mitchmindtree
force-pushed
the
rusttype-0.9.2
branch
from
594c600 to
b6f5083
Compare
mitchmindtree
changed the title
mitchmindtree
changed the title
Also removes some unnecessary buffering of positioned glyphs. The patch required fixes an otherwise inconsolable lifetime issue related to the positioned glyphs yielded by a font's layout method.
…text rendering API tweaks
mitchmindtree
force-pushed
the
rusttype-0.9.2
branch
from
e717586 to
a473f7c
Compare
|
It looks like we can still get away with using I think we're probably better off sticking to 0.8.3 for now, at least until either rusttype gets a new maintainer or someone is motivated enough to switch over to the The vulkano CI breakage is unrelated (see #1409). |
mitchmindtree
added a commit
to mitchmindtree/conrod
that referenced
this pull request
Apr 15, 2021
Changes include: - Update to rusttype 0.8.3 with more efficient text rendering PistonDevelopers#1411. This slightly affects how the `Text` render primitive is handled. Folks with custom conrod backends may want to take a peak at this PR to see how to update. - Update to wgpu 0.7 and winit 0.24 in `conrod_wgpu`. PistonDevelopers#1413 - Reduce deps by updating to `num` 0.3. PistonDevelopers#1395 NOTE: `conrod_vulkano` will be excluded from this version update due to `vk-sys` publishing a breaking change not too long ago. See PistonDevelopers#1409.
Merged
mitchmindtree
added a commit
to mitchmindtree/conrod
that referenced
this pull request
Apr 15, 2021
Changes include: - Update to rusttype 0.8.3 with more efficient text rendering PistonDevelopers#1411. This slightly affects how the `Text` render primitive is handled. Folks with custom conrod backends may want to take a peak at this PR to see how to update. - Update to wgpu 0.7 and winit 0.24 in `conrod_wgpu`. PistonDevelopers#1413 - Reduce deps by updating to `num` 0.3. PistonDevelopers#1395 NOTE: `conrod_vulkano` will be excluded from this version update due to `vk-sys` publishing a breaking change not too long ago. See PistonDevelopers#1409.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes some unnecessary buffering of positioned glyphs.
Edit: For context on the following, this PR originally tried updating to 0.9.2.
Landing this is blocked on a patch that exists on rusttype master but has not yet been released:
https://gitlab.redox-os.org/redox-os/rusttype/-/merge_requests/158
Unfortunately, rusttype is currently lacking a maintainer and as a result it's hard to say when/if we'll be able to land this:
https://gitlab.redox-os.org/redox-os/rusttype/-/issues/148