Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking Change] Fix bug in parent widget inference. Simplify Widget::default_*_dimension methods as a result. #656

Merged

Conversation

mitchmindtree
Copy link
Contributor

@bvssvni this fixes #655 .

…n of default dimensions and calculating xy coords. Remove unnecessary Option from return type on default_dimension methods (as a result, this is a breaking change).
@mitchmindtree
Copy link
Contributor Author

Travis is failing due to a regression in the latest nightly. Going to merge as it builds fine on stable 1.5.

@mitchmindtree
Copy link
Contributor Author

Uploaded as 0.28.0.

mitchmindtree added a commit that referenced this pull request Dec 23, 2015
[Breaking Change] Fix bug in parent widget inference. Simplify Widget::default_*_dimension methods as a result.
@mitchmindtree mitchmindtree merged commit f4d331c into PistonDevelopers:master Dec 23, 2015
@mitchmindtree mitchmindtree deleted the parent_inference_fix branch January 8, 2016 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Widgets centered on first frame
1 participant