Remove unnecessary inline hints causing bloated stack size (and in turn overflowing the stack) in downstream crates #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rn overflowing the stack) in downstream crates
|
Published as 0.37.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've run into several stack overflows using conrod over the past couple of days, only when compiling in release. When instantiating many widgets (i.e. via helper macros), the large amount of inlining lead to a huge stack size that overflowed the designated 8mb stack on my OS X release build. This fixes the problem and hasn't caused any noticeable difference in performance. It seems that in this case, it's best to let LLVM automatically infer what cases are best for inlining. Perhaps it uses some sort of main-thread stack size consideration when deciding upon what to inline?