-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include glfw as a submodule, update to 3.3.9 #28
Conversation
Merging. |
Thanks! |
The CI is failing but apparently that's because the CI was set up for GLFW, not the rust wrapper. Didn't catch this because of github's "first time contributor" thing :( I can send a PR with a CI which tests rust crate. |
@MaxVerevkin I'm having problems on OSX. Could this be a submodule issue? |
Probably no. What exactly fails? |
|
@bvssvni Can you try running |
@MaxVerevkin Works, thanks! |
@MaxVerevkin Can you fix CI? |
I've merged the version bump, but not published yet so you can pull before you send the PR. |
Yep, working on it. |
I think the readme should be update too. |
Closes #3