Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include glfw as a submodule, update to 3.3.9 #28

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

MaxVerevkin
Copy link

@MaxVerevkin MaxVerevkin commented Dec 18, 2023

Closes #3

@bvssvni
Copy link
Member

bvssvni commented Jan 19, 2024

Merging.

@bvssvni bvssvni merged commit b7e2034 into PistonDevelopers:master Jan 19, 2024
@bvssvni
Copy link
Member

bvssvni commented Jan 19, 2024

Thanks!

@MaxVerevkin MaxVerevkin deleted the submod branch January 19, 2024 20:02
@MaxVerevkin
Copy link
Author

The CI is failing but apparently that's because the CI was set up for GLFW, not the rust wrapper. Didn't catch this because of github's "first time contributor" thing :( I can send a PR with a CI which tests rust crate.

@bvssvni
Copy link
Member

bvssvni commented Jan 19, 2024

@MaxVerevkin I'm having problems on OSX. Could this be a submodule issue?

@MaxVerevkin
Copy link
Author

Could this be a submodule issue?

Probably no. What exactly fails?

@bvssvni
Copy link
Member

bvssvni commented Jan 19, 2024

% cargo test
   Compiling glfw-sys v4.0.0+3.3.9 (/Users/sven/rust/glfw-sys)
error: failed to run custom build command for `glfw-sys v4.0.0+3.3.9 (/Users/sven/rust/glfw-sys)`

Caused by:
  process didn't exit successfully: `/Users/sven/rust/glfw-sys/target/debug/build/glfw-sys-6fa64f2c9a28559a/build-script-build` (exit status: 101)
  --- stdout
  CMAKE_TOOLCHAIN_FILE_aarch64-apple-darwin = None
  CMAKE_TOOLCHAIN_FILE_aarch64_apple_darwin = None
  HOST_CMAKE_TOOLCHAIN_FILE = None
  CMAKE_TOOLCHAIN_FILE = None
  CMAKE_GENERATOR_aarch64-apple-darwin = None
  CMAKE_GENERATOR_aarch64_apple_darwin = None
  HOST_CMAKE_GENERATOR = None
  CMAKE_GENERATOR = None
  CMAKE_PREFIX_PATH_aarch64-apple-darwin = None
  CMAKE_PREFIX_PATH_aarch64_apple_darwin = None
  HOST_CMAKE_PREFIX_PATH = None
  CMAKE_PREFIX_PATH = None
  CMAKE_aarch64-apple-darwin = None
  CMAKE_aarch64_apple_darwin = None
  HOST_CMAKE = None
  CMAKE = None
  running: cd "/Users/sven/rust/glfw-sys/target/debug/build/glfw-sys-2b3d4b4d29c9803c/out/build" && CMAKE_PREFIX_PATH="" "cmake" "/Users/sven/rust/glfw-sys/glfw" "-DCMAKE_OSX_ARCHITECTURES=arm64" "-DGLFW_BUILD_EXAMPLES=OFF" "-DGLFW_BUILD_TESTS=OFF" "-DGLFW_BUILD_DOCS=OFF" "-DCMAKE_INSTALL_LIBDIR=lib" "-DGLFW_USE_WAYLAND=OFF" "-DCMAKE_INSTALL_PREFIX=/Users/sven/rust/glfw-sys/target/debug/build/glfw-sys-2b3d4b4d29c9803c/out" "-DCMAKE_C_FLAGS= -ffunction-sections -fdata-sections -fPIC -arch arm64" "-DCMAKE_C_COMPILER=/usr/bin/cc" "-DCMAKE_CXX_FLAGS= -ffunction-sections -fdata-sections -fPIC -arch arm64" "-DCMAKE_CXX_COMPILER=/usr/bin/c++" "-DCMAKE_ASM_FLAGS= -ffunction-sections -fdata-sections -fPIC -arch arm64" "-DCMAKE_ASM_COMPILER=/usr/bin/cc" "-DCMAKE_BUILD_TYPE=Debug"

  --- stderr
  CMake Error: The source directory "/Users/sven/rust/glfw-sys/glfw" does not appear to contain CMakeLists.txt.
  Specify --help for usage, or press the help button on the CMake GUI.
  thread 'main' panicked at /Users/sven/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cmake-0.1.50/src/lib.rs:1098:5:

  command did not execute successfully, got: exit status: 1

  build script failed, must exit now
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@MaxVerevkin
Copy link
Author

@bvssvni Can you try running git submodule update --init --recursive?

@bvssvni
Copy link
Member

bvssvni commented Jan 19, 2024

@MaxVerevkin Works, thanks!

@MaxVerevkin MaxVerevkin deleted the submod branch January 19, 2024 20:14
@bvssvni
Copy link
Member

bvssvni commented Jan 19, 2024

@MaxVerevkin Can you fix CI?

@bvssvni
Copy link
Member

bvssvni commented Jan 19, 2024

I've merged the version bump, but not published yet so you can pull before you send the PR.

@MaxVerevkin
Copy link
Author

@MaxVerevkin Can you fix CI?

Yep, working on it.

@MaxVerevkin
Copy link
Author

I think the readme should be update too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge changes from glfw
2 participants