Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serde support for deserializing long arrays #41

Merged
merged 1 commit into from
Aug 6, 2019

Conversation

caelunshun
Copy link
Contributor

@caelunshun caelunshun commented Aug 5, 2019

This allows hematite-nbt to be used for deserializing 1.13.2 region files.

Resolves #32.

@atheriel
Copy link
Collaborator

atheriel commented Aug 6, 2019

Thanks for taking the initiative on this. If I understand correctly, this only implements deserialziation, so it does not completely resolve #32 (which would also require serialization support).

Have you successfully deserialized a region file using this patch?

@caelunshun
Copy link
Contributor Author

Thanks for taking the initiative on this. If I understand correctly, this only implements deserialziation, so it does not completely resolve #32 (which would also require serialization support).

That's correct. The root issue for this is #27, which means that a long array would be written as a TAG_List rather than a TAG_Long_Array. The same happens with int/byte arrays as well.

Have you successfully deserialized a region file using this patch?

Yep - see this.

@atheriel atheriel merged commit a748614 into PistonDevelopers:master Aug 6, 2019
@atheriel
Copy link
Collaborator

atheriel commented Aug 6, 2019

Nice to see some ongoing work on Minecraft in Rust, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add serde support for TAG_LongArray
2 participants