feat: use llvm new pass manager api #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #352 +/- ##
==========================================
- Coverage 85.82% 85.79% -0.03%
==========================================
Files 108 108
Lines 23987 23983 -4
==========================================
- Hits 20587 20577 -10
- Misses 3400 3406 +6
|
Benchmark for 45b6b7eClick to view benchmark
|
xieyuschen
previously approved these changes
Nov 30, 2023
| let mpm: inkwell::passes::PassManager<Module> = | ||
| unsafe { inkwell::passes::PassManager::new(ptr) }; | ||
|
|
||
| // let ptr = unsafe { llvm_sys::core::LLVMCreatePassManager() }; |
| #include "llvm-c/Transforms/PassBuilder.h" | ||
|
|
||
| // param: opt opt level | ||
| extern "C" void run_module_pass(LLVMModuleRef M, int opt) { |
There was a problem hiding this comment.
could add a comment about run_module_pass to explain:
- what does this function do
- which llvm API it calls(add a llvm link if possible)
- the mapping between optimization level and integer.
immix/llvm/plimmix.cpp
Outdated
| @@ -30,9 +30,68 @@ extern "C" void LLVMLinkPLImmixGC() | |||
| #include "llvm-c/Transforms/PassManagerBuilder.h" | |||
|
|
|||
| extern "C" void add_module_pass(llvm::legacy::PassManagerBase * PB) { | |||
There was a problem hiding this comment.
Suggested change
| extern "C" void add_module_pass(llvm::legacy::PassManagerBase * PB) { | |
| extern "C" void add_module_pass(llvm::legacy::PassManagerBase *PB) { |
immix/llvm/plimmix.cpp
Outdated
Comment on lines
36
to
40
| #include "llvm/Passes/PassBuilder.h" | ||
| #include "llvm/Passes/PassPlugin.h" | ||
|
|
||
| #include "llvm-c/Types.h" | ||
| #include "llvm-c/Transforms/PassBuilder.h" |
There was a problem hiding this comment.
should we put all files at the top of this file?
| // [](const llvm::PassManagerBuilder &Builder, | ||
| // llvm::legacy::PassManagerBase &PM) | ||
| // { PM.add(new Immix()); }); | ||
| // char ImmixPass::ID = 0; |
| { | ||
| for (auto FB = M.functions().begin(), FE = M.functions().end(); FB != FE; ++FB) | ||
| { | ||
| Function *FV = &*FB; |
There was a problem hiding this comment.
just curious, why not use FB directly
Benchmark for 98a8e28Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.