-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: make performance great again #439
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FIX: fixed a generic method look up issue
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #439 +/- ##
==========================================
- Coverage 85.05% 84.87% -0.18%
==========================================
Files 99 99
Lines 26147 26390 +243
==========================================
+ Hits 22239 22399 +160
- Misses 3908 3991 +83
|
Chronostasys
force-pushed
the
perf/gc
branch
16 times, most recently
from
December 19, 2024 17:56
8eba8d4
to
b214e95
Compare
Chronostasys
force-pushed
the
perf/gc
branch
3 times, most recently
from
December 19, 2024 18:38
6f27e1b
to
6e46f1a
Compare
Chronostasys
force-pushed
the
perf/gc
branch
from
December 19, 2024 18:46
6e46f1a
to
22b3e21
Compare
Chronostasys
force-pushed
the
perf/gc
branch
from
December 29, 2024 09:57
fbedcd3
to
8ad1dba
Compare
Chronostasys
force-pushed
the
perf/gc
branch
from
December 29, 2024 10:04
8ad1dba
to
6d5edf8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a massive performance update.
With this update, the ray trace program is about 20x faster than before, we even beat the golang implementation on my computer (MacBook Pro M2 13-inch 16GB).
Main changes:
Bugfixes:
if let ... impl ...
statement if the type isn't satisfy the condition.TODOS:
chase_lev
to make GC mark load of each thread more balance.