Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add full size preview & fix fc on Android 12L and 13 #144

Merged
merged 3 commits into from
Feb 28, 2023

Conversation

xsm1997
Copy link
Contributor

@xsm1997 xsm1997 commented Feb 9, 2023

The PR allows user to view the full (original) size of images on preview.

Note that cookies should be included when getting images, to be compatible with original_url_protection.

The PR also fixes a FC on some Android 12L and Android 13 ROM. Reference: https://stackoverflow.com/questions/74163927/flutter-chrash-in-android-12l-with-no-interface-method-addwindowlayoutinfoliste

The FC is related to androidx.window:window and it is fixed in 1.1.0-alpha04. Because it is an alpha version, the stable version 1.0.0 is used instead, which also does not have the problem.

@remi-martin
Copy link
Collaborator

Hi, thanks for your contribution, I'll check that ...

@remi-martin remi-martin merged commit 8012d8e into Piwigo:Dev/v2 Feb 28, 2023
@daetsch
Copy link

daetsch commented Apr 19, 2023

Just downloaded and tested 2.0.2-beta. Seems that local caching works very good now and very good speed enhancement overall. Full Size pictures works. Very well development. Thanks a lot for your effort and keep going :-)

@remi-martin
Copy link
Collaborator

That's good to hear 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants