Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we eliminate the use of boost shared pointers? (BOOST_SP_USE_STD_ATOMIC problem) #170

Closed
meshula opened this issue Mar 3, 2017 · 4 comments
Closed

Can we eliminate the use of boost shared pointers? (BOOST_SP_USE_STD_ATOMIC problem) #170

meshula opened this issue Mar 3, 2017 · 4 comments

Comments

@meshula
Copy link
Member

meshula commented Mar 3, 2017

There is a difficult USD configuration issue around the use of boost shared pointers.

This flag

BOOST_SP_USE_STD_ATOMIC

exists as a preprocessor directive, and it is impossible to tell if a compiled version of boost was made with it set to 1 or not.

If you are trying to build USD against a supplied version of boost, instead of one built specifically for USD, it's extremely difficult to narrow the issues down to this flag, and then to work out how to set it.

I would request that we don't use boost shared pointers at all, since for the most part the functionality is covered by std or tbb.
@jtran56
Copy link

jtran56 commented Mar 3, 2017

Filed as internal issue #143729.

@waywardmonkeys
Copy link
Contributor

I have a branch that seems to do this. It is currently, without all of the requisite cleanup, modifying about 170 files.

To avoid repeatedly rebasing this ... is there a good time to submit it as a pull request?

@waywardmonkeys waywardmonkeys mentioned this issue Jan 23, 2018
Closed
@meshula
Copy link
Member Author

meshula commented Feb 1, 2018

I just wanted to check in and say that this is still an issue.

waywardmonkeys added a commit to waywardmonkeys/USD that referenced this issue Feb 1, 2018
@waywardmonkeys
Switch from boost::shared_ptr to std::shared_ptr.
694398d 
This converts from using `boost::shared_ptr` and friends
(like `weak_ptr`) over to using the `std` equivalents.

Fixes issue PixarAnimationStudios#170.
@Felix-Kit Felix-Kit mentioned this issue Feb 9, 2022
Closed
@nvmkuruc
Copy link
Collaborator

@meshula @jesschimein I think this issue can be closed.

@meshula meshula closed this as completed Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@waywardmonkeys @meshula @jtran56 @nvmkuruc