better detection of python lib / include dirs in build_usd.py #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed as internal issue #USD-7040 |
|
Any word on this PR? I understand that it might be hard to test, but the various |
sunyab
requested changes
Jan 8, 2022
There was a problem hiding this comment.
I tested this out in a few places -- on Windows this seems to work great and fixes venv-related build issues reported elsewhere (#1542, for example). However on my Linux workstation it doesn't give me the right results. I left a comment below with further details.
This addresses two issues:
- Building using a venv-installed python
- The venv-installed pythons would try to pull the libraries from
the venv-directory, when they only reside at the "original"\
installed python location
- Building with a python that was moved after building on Linux
- We experienced issues where the `INCLUDEPY` and `LIBDIR` sysconfig
vars were baked at build time. Thus these would no longer be
reliable if running a python executable that was moved to a
different location after building.
Note that or python-2.7, `installed_base` doesn't exist, so we fall back
to `base`. This should be fairly backward-compatible, as we check if
the dir (for include) or file (for lib) doesn't exist, and try alternate
methods if not.
pmolodo
force-pushed
the
pr/build_usd_GetPythonInfo
branch
from
7f388b0
to
535f6da
Compare
sunyab
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
This addresses two issues:
Building using a venv-installed python
the venv-directory, when they only reside at the "original"
installed python location
Building with a python that was moved after building on Linux
INCLUDEPYandLIBDIRsysconfigvars were baked at build time. Thus these would no longer be
reliable if running a python executable that was moved to a
different location after building.
Note that on python-2.7,
installed_basedoesn't exist, so we fall backto
base. Also we fall back toINCLUDEPYandLIBDIRif theinstalled_base/basemethod doesn't work, so this should be fairlybackward compatible.