Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build-script] exclude boost lib 'wave' utf-8 test files from extraction #1694

Conversation

davidlatwe
Copy link
Contributor

Description of Change(s)

In build-script, exclude libs/wave/test/testwave/testfiles/utf8-test-ßµ™∃ dir from the extraction of Boost archive.

Fixes Issue(s)

When buliding USD with Python-2, I keep getting following error (on Windows)

Building with settings:
  USD source directory          c:\..\usd\21.08\build\platform-windows\python-2.7\USD-21.08
  USD install directory         D:\payload
  3rd-party source directory    D:\payload\src
  3rd-party install directory   D:\payload
  Build directory               D:\payload\build
  CMake generator               Default
  CMake toolset                 Default
  Downloader                    curl

  Building                      Shared libraries
    Config                      Release
    Imaging                     On
      Ptex support:             Off
      OpenVDB support:          Off
      OpenImageIO support:      Off
      OpenColorIO support:      Off
      PRMan support:            Off
    UsdImaging                  On
      usdview:                  On
    Python support              On
      Python 3:                 Off
    Documentation               Off
    Tests                       Off
    Examples                    On
    Tutorials                   On
    Tools                       On
    Alembic Plugin              Off
      HDF5 support:             Off
    Draco Plugin                Off
    MaterialX Plugin            Off

  Dependencies                  zlib, boost, TBB, OpenSubdiv
  Build arguments               USD: "-DPXR_STRICT_BUILD_MODE=OFF"
STATUS: Installing zlib...
STATUS: Installing boost...
ERROR: Failed to extract archive boost_1_70_0.tar.gz: [Error 123] The filename, directory name, or volume label syntax is incorrect.: 'D:\\payload\\src\\extract_dir\\boost_1_70_0\\libs\\wave\\test\\testwave\\testfiles
\\utf8-test-\xc3\x9f\xc2\xb5\xe2\x84\xa2\xe2\x88\x83'
Traceback (most recent call last):
  File "c:\..\usd\21.08/rezbuild.py", line 115, in <module>
    targets=sys.argv[1:])
  File "c:\..\usd\21.08/rezbuild.py", line 82, in build
    env=env,
  File "C:\python27_64\lib\subprocess.py", line 190, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['python', 'c:\\..\\usd\\21.08\\build\\platform-windows\\python-2.7\\USD-21.08/build_scripts/build_usd.py', '--build-arg=USD,"-DPXR_STRICT_BUILD_MODE=OFF"', 'D:payload']' returned non-zero exit status 1

Thanks to the DownloadURL() function's arg dontExtract, this issue can be handled easily.

The other route that I've tried was to make DownloadURL() able to handle unicode in Python-2, but just excluding that specific dir is enough for now.

@jilliene
Copy link

Filed as internal issue #USD-7042

@pixar-oss pixar-oss merged commit 32d0e51 into PixarAnimationStudios:dev Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants