Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace boost::iterator_adaptor with explicitly specified iterator definition for UsdPrimRange #2232

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

nvmkuruc
Copy link
Collaborator

@nvmkuruc nvmkuruc commented Feb 1, 2023

Description of Change(s)

  • Introduces an _UnderlyingIterator type alias for Usd_PrimDataConstPtr in UsdPrimRange::iterator
  • Introduces a _PtrProxy private class to be used as the pointer type for UsdPrimRange::iterator. This special proxy is required because UsdPrimRange::reference is not a true reference type and it's not safe to take the address of a temporary.
  • Explicitly implement the increment, dereference, and arrow operators for UsdPrimRange::iterator

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@tallytalwar
Copy link
Contributor

Filed as internal issue #USD-7960

@pixar-oss pixar-oss merged commit 03de66d into PixarAnimationStudios:dev Jul 27, 2023
@nvmkuruc nvmkuruc deleted the usdprimrangeadaptor branch December 29, 2023 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants