Replace boost::iterator_facade with explicit implementation for pcp/node.h
#2389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvmkuruc
changed the title
with explicit implementation for pcp/node.h`boost::iterator_facade with explicit implementation for pcp/node.h
|
Filed as internal issue #USD-8252 |
crevilla
reviewed
Jul 14, 2023
| @@ -372,8 +369,28 @@ class PcpNodeRef_ChildrenIterator | |||
| PCP_API | |||
| PcpNodeRef_ChildrenIterator(const PcpNodeRef& node, bool end = false); | |||
|
|
|||
There was a problem hiding this comment.
I'm pretty confident that you will need operator-> for both of these iterator classes. They're exposed publicly as child_const_iterator and child_const_reverse_iterator (via typedef) and I can confirm that at least the maya open source code uses these iterators and dereferences via ->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
iterator_facadewith explicit operators forPcpNodeRef_ChildrenIteratorandPcpNodeRef_ChildrenReverseIteratorFixes Issue(s)
boost::iterator_facadeusage with fully specified iterator classes #2305