Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autodesk: Configurable anisotropic filtering #3216

Conversation

AdamFelt
Copy link
Contributor

@AdamFelt AdamFelt commented Aug 8, 2024

Description of Change(s)

Make anisotropic filtering configurable. See issue #3180 for rationale.

Expose maxAnisotropy in HgiSamplerDesc
Define an environment setting HGI_MAX_ANISOTROPY as an override for the implementation max anisotropy
Update current users of textures/samplers to disable anisotropy when not needed (like dome lighting texture)

Fixes Issue(s)

Mostly fixes #3180, but more work should be done to configure anisotropic filtering from the materials (can be a separate issue).

  • [X ] I have verified that all unit tests pass with the proposed changes
  • [X ] I have submitted a signed Contributor License Agreement

@jesschimein
Copy link
Contributor

Filed as internal issue #USD-9957

❗ Please make sure that a signed CLA has been submitted!

@jesschimein
Copy link
Contributor

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DDoS DDoS force-pushed the adsk/feature/better-aniso-use branch from 97b739a to 1f45471 Compare August 12, 2024 16:37
@jesschimein
Copy link
Contributor

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DDoS DDoS force-pushed the adsk/feature/better-aniso-use branch from 1f45471 to c2585a0 Compare August 12, 2024 20:00
@AdamFelt
Copy link
Contributor Author

Filed as internal issue #USD-9957

❗ Please make sure that a signed CLA has been submitted!

Can you please verify that I am on the Autodesk CLA.

@jesschimein
Copy link
Contributor

Sorry for the confusion! Yes, you are on the Autodesk CLA!

@AdamFelt AdamFelt changed the title Configurable anisotropic filtering Autodesk: Configurable anisotropic filtering Aug 13, 2024
@jesschimein
Copy link
Contributor

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pixar-oss pixar-oss merged commit 90d0f6a into PixarAnimationStudios:dev Aug 22, 2024
5 checks passed
@erikaharrison-adsk erikaharrison-adsk deleted the adsk/feature/better-aniso-use branch September 18, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants