Autodesk: Fix leaking Vulkan buffer from HdSt_PipelineDrawBatch #3313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This went undetected by the validation layer because the tests were also leaking the Vulkan instance and device, so they were never destroyed, and the validation check never kicked in. So fix the leaking tests too. This also fixes an occasional crash from a driver trying to use a resource after the tests had exited main(), because the HgiVulkan leak also meant no synchronization.
|
Filed as internal issue #USD-10181 |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
clach
merged commit f2fb0c9
into
PixarAnimationStudios:feature-hgi-vulkan
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
This went undetected by the validation layer because the tests were also leaking the Vulkan instance and device, so they were never destroyed, and the validation check never kicked in. So fix the leaking tests too.
This also fixes an occasional crash from a driver trying to use a resource after the tests had exited main(), because the HgiVulkan leak also meant no synchronization.
Added some more buffer naming to help debug the leak and included it in the PR as it's useful for debugging.
Fixes Issue(s)