refactor(): add rambling comments to dynamic forms files #3773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Si3rr4wow
commented
Aug 16, 2024
| @@ -1,12 +1,17 @@ | |||
| { | |||
| "jest.jestCommandLine": "node --experimental-vm-modules node_modules/jest/bin/jest.js", | |||
There was a problem hiding this comment.
oops didn't mean to commit this, will remove
Si3rr4wow
commented
Sep 13, 2024
Comment on lines
+9
to
+12
| // A good first step would be moving the use of getJourney into | ||
| // a single piece of middleware since it's only used in handlers. | ||
| // That way it'll be easier to clean up the use of getJourney | ||
| // once Journey itself has been refactored. |
There was a problem hiding this comment.
This is almost done #3782
Si3rr4wow
commented
Sep 13, 2024
Comment on lines
+5
to
+6
| // Having searched the codebase from "new Question" to no avail, I seem to | ||
| // recall there's some bizarre programmatic instantiation going on somewhere. |
There was a problem hiding this comment.
I was thinking of Journeys, but that doesn't happen anymore. I think this class is just "abstract" and the other questions extend it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket Number
https://pins-ds.atlassian.net/browse/AAPD-
Description of change
Checklist
Important
Please do not merge from
main(please only rebase). This keeps the history linear and easier to debug.