Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/a2 1589 update pdf service #4008

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

bryn-pins
Copy link
Contributor

@bryn-pins bryn-pins commented Jan 2, 2025

Ticket Number

https://pins-ds.atlassian.net/browse/A2-1589

Description of change

  • updates the pdf service to use alpine linux with chromium installed as a apk package
  • updates the puppeteer version and switches to use puppeteer-core as we are managing our own browser instance in alpine

waiting on dependency clean up PR

After:
image

Checklist

  • Requires infrastructure changes
  • I have updated the documentation accordingly
  • My commit history in this PR is linear
  • New features have tests
  • Breaking change (team conversation required)

Important

Please do not merge from main (please only rebase). This keeps the history linear and easier to debug.

@bryn-pins bryn-pins mentioned this pull request Jan 3, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant