Task/dev275 tf upgrades #571
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Had to delete the .terraform folder and then re-run tf init as it was erroring |
m-juckes-pins
commented
Oct 22, 2024
infrastructure/app-api.tf
Outdated
| @@ -97,8 +97,8 @@ module "app_api" { | |||
| } | |||
|
|
|||
| providers = { | |||
| azurerm = azurerm | |||
| azurerm.tooling = azurerm.tooling | |||
There was a problem hiding this comment.
This couldn't pass the validation with it in
│ Error: Cannot override provider configuration
│
│ on app-api.tf line 101, in module "app_api":
│ 101: azurerm.tooling = azurerm.tooling
│
│ The configuration of module.app_api has its own local configuration for azurerm.tooling, and so it cannot accept an overridden configuration provided by the root module.
This comment was marked as outdated.
This comment was marked as outdated.
|
Tflint needs to be at root level also for it to work with pre-commits |
This comment was marked as outdated.
This comment was marked as outdated.
…rm block from the module itself and tagged to latest github commit
m-juckes-pins
commented
Oct 24, 2024
| skip_provider_registration = true | ||
| alias = "horizon" | ||
| subscription_id = var.horizon_infra_config.subscription_id | ||
| resource_provider_registrations = "none" |
There was a problem hiding this comment.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/guides/4.0-upgrade-guide
Upgrading Terraform from version 3 -> 4.5.0
---- The flag is obsolete because the goal is to have each namespace AZ by default in the supported regions.
---- Registration: Some resource providers need to be registered manually before you can use them
Issue ticket number and link
Type of change 🧩
Checklist before requesting a review