Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(appeals): add environmental impact assessment screening page (a2-1882) #785

Merged

Conversation

BenSurgisonPINS
Copy link
Collaborator

@BenSurgisonPINS BenSurgisonPINS commented Dec 30, 2024

Describe your changes

WEB:

  • Added a new route, mapper, and validator for the new page.
  • Updated the service and type to include the new eiaScreeningRequired field
  • Redirect to the new page when the lpa questionnaire is confirmed and when the appeal type is not Householder.
  • Enhance the hint within the radios component so that html as well as a string can be used to allow for paragraphs and a link as required in the ticket.

API:

  • Added the eiaScreeningRequired field to the prisma schema for the appeals table and ran the db migrate
  • Added a new route for saving the eiaScreeningRequired field and updated schemas as well as the swagger definition
  • Updated the repository to save the new field

TESTING:

  • WEB added unit tests and checked all other tests pass.
  • API checked all tests pass
  • Manually tested within browser

Issue ticket number and link

A2-1882 Boolean - Does the environmental services team need to review the case?

Note there is a screenshot of the new design seen in a comment in the ticket above

Type of change 🧩

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please explain in the description section above)

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have double checked this work does not include any hardcoded secrets or passwords
  • I have made corresponding changes to the documentation
  • I have provided details on how I have tested my code
  • I have referenced the ticket number above
  • I have provided a description of the ticket
  • I have included unit tests to cover any testable code changes

@BenSurgisonPINS BenSurgisonPINS self-assigned this Dec 30, 2024
@BenSurgisonPINS BenSurgisonPINS marked this pull request as ready for review January 2, 2025 11:21
@BenSurgisonPINS BenSurgisonPINS force-pushed the feat/a2-1882-environmental-impact-assessment-screening branch 8 times, most recently from 0052b58 to 919a5c2 Compare January 2, 2025 17:17
@BenSurgisonPINS BenSurgisonPINS changed the title feat(appeals): add environmental impact assessment screening page (a2… feat(appeals): add environmental impact assessment screening page (a2-1882) Jan 2, 2025
@BenSurgisonPINS BenSurgisonPINS force-pushed the feat/a2-1882-environmental-impact-assessment-screening branch from 919a5c2 to a9045a6 Compare January 3, 2025 10:00
@BenSurgisonPINS BenSurgisonPINS marked this pull request as draft January 3, 2025 10:01
@BenSurgisonPINS BenSurgisonPINS force-pushed the feat/a2-1882-environmental-impact-assessment-screening branch 2 times, most recently from aa7450b to 8a140d0 Compare January 3, 2025 17:34
@BenSurgisonPINS BenSurgisonPINS marked this pull request as ready for review January 3, 2025 17:35
fabfab-kc
fabfab-kc previously approved these changes Jan 6, 2025
Copy link
Collaborator

@fabfab-kc fabfab-kc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BenSurgisonPINS BenSurgisonPINS added this pull request to the merge queue Jan 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jan 6, 2025
@BenSurgisonPINS BenSurgisonPINS force-pushed the feat/a2-1882-environmental-impact-assessment-screening branch from 8a140d0 to f1af405 Compare January 6, 2025 10:17
@BenSurgisonPINS BenSurgisonPINS added this pull request to the merge queue Jan 6, 2025
Merged via the queue into main with commit d967709 Jan 6, 2025
7 checks passed
@BenSurgisonPINS BenSurgisonPINS deleted the feat/a2-1882-environmental-impact-assessment-screening branch January 6, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants