Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get application endpoint filters and pagination backoffice #1014

Merged
merged 5 commits into from
Feb 8, 2024

Conversation

Yakitrak
Copy link
Collaborator

@Yakitrak Yakitrak commented Feb 6, 2024

Describe your changes

Ticket: https://pins-ds.atlassian.net/browse/ASB-2190

PR adds pagination and filtering for get all application for back office. This is completion the work done in #998.

Type of change 🧩

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please explain in the description section above)

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have double checked this work does not include any hardcoded secrets or passwords
  • I have made corresponding changes to the documentation
  • I have provided details on how I have tested my code
  • I have referenced the ticket number above
  • I have provided a description of the ticket
  • I have included unit tests to cover any testable code changes

@Yakitrak Yakitrak self-assigned this Feb 6, 2024
…service into feature/asb-2190-all-applications-paginationafilters
Copy link
Contributor

@Philip-Philippou1 Philip-Philippou1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mentioned having added more test data locally was that worth adding here or was it test data loaded in manually that doesn't fit with seed script?

…service into feature/asb-2190-all-applications-paginationafilters
@Yakitrak Yakitrak merged commit a270d9f into main Feb 8, 2024
7 checks passed
@Yakitrak Yakitrak deleted the feature/asb-2190-all-applications-paginationafilters branch February 8, 2024 15:20
@AnthonyJWalsh
Copy link
Contributor

🎉 This PR is included in version 1.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@AnthonyJWalsh
Copy link
Contributor

🎉 This PR is included in version 2.18.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@AnthonyJWalsh
Copy link
Contributor

🎉 This PR is included in version 2.23.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants