Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove all legacy NI and make BO default #1238

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Yakitrak
Copy link
Collaborator

@Yakitrak Yakitrak commented Jul 10, 2024

Describe your changes

Ticket: https://pins-ds.atlassian.net/browse/APPLICS-598

Cleans up all NI related code including db models, connection, repositories, services and mappers etc. The default and only data source is back-office. All tests are also updated.

We cannot merge this until we are fully migrated and don't need a hybrid approach. When the time comes, this PR should be mergable AFTER regression testing although at the time of writing it is working locally. If it becomes out of date, it serves as documentation to show developers what can be removed and refactored.

Type of change 🧩

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please explain in the description section above)

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have double checked this work does not include any hardcoded secrets or passwords
  • I have made corresponding changes to the documentation
  • I have provided details on how I have tested my code
  • I have referenced the ticket number above
  • I have provided a description of the ticket
  • I have included unit tests to cover any testable code changes

@Yakitrak Yakitrak added the do not merge Do not merge label Jul 10, 2024
@Yakitrak Yakitrak self-assigned this Jul 10, 2024
@Yakitrak Yakitrak force-pushed the feature/cleanup-integration-spike branch from eb4cedf to c50ede9 Compare July 10, 2024 13:11
@Yakitrak Yakitrak changed the title feat: remove all legacy NI code and make BO default feat: remove all legacy NI and make BO default Jul 10, 2024
@Yakitrak Yakitrak requested a review from beejjacobs July 10, 2024 13:16
@Yakitrak Yakitrak marked this pull request as draft July 12, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Do not merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant