Skip to content
This repository has been archived by the owner on Jan 16, 2024. It is now read-only.

PledgeEvents v1.2 #1685

Closed
1 of 5 tasks
norbertschuler opened this issue Nov 30, 2019 · 6 comments · Fixed by #1731
Closed
1 of 5 tasks

PledgeEvents v1.2 #1685

norbertschuler opened this issue Nov 30, 2019 · 6 comments · Fixed by #1731
Assignees
Labels
bug Something isn't working

Comments

@norbertschuler
Copy link
Collaborator

norbertschuler commented Nov 30, 2019

  • Add validation in the pledge Increment screen
  • Currently it is possible to reduce pledges, api returns error but app does not react.
  • Show all details in the Pledge Increment Screen
    (allow user to change name or toggle anonymous status, disable email field)
  • Fix headers, remove title, and remove spacing
  • Refresh the page after pledge is updated (including the total pledged tree count)
@norbertschuler norbertschuler added bug Something isn't working enhancement New feature or request and removed enhancement New feature or request labels Nov 30, 2019
@harshvitra
Copy link
Collaborator

@jmiridis
allow user to change name or toggle anonymous status, disable email field

Need an Edit Pledge API which can allow the user to edit these fields

  1. First Name
  2. Last Name
  3. Email
  4. Tree Count
  5. Is Anonymous Status

@harshvitra
Copy link
Collaborator

Hey @norbertschuler can you explain these issues

Is number 1 and 2 the same or different ?

Fix headers, remove titles, and remove spacing - Need more ideas on this ?

Refresh the page - Which page ? In the app or website ? Mostly I’m guessing Pledge Events screen on App.

@norbertschuler
Copy link
Collaborator Author

Discussion done in Slack (just to inform any possible reader here).

@harshvitra
Copy link
Collaborator

harshvitra commented Dec 3, 2019

For others to be clear

  • Add validation in the pledge Increment screen
  • Currently it is possible to reduce pledges, api returns error but app does not react.

These are listed as 2 different but are the same


  • Show all details in the Pledge Increment Screen (allow user to change name or toggle anonymous status, disable email field)

So user can change everything and NOT change email


  • Fix headers, remove title, and remove spacing
  1. Fixing: Removing Search icon, changing color
  2. Remove title: removing titles and adding them in header
  3. Remove spacing: unnecessary space in pledge events

  • Refresh the page after pledge is updated (including the total pledged tree count)

This still needs to be tested and replicated
Cannot test since I cant create Pledges as of now due to error

@harshvitra
Copy link
Collaborator

@jmiridis can we fix #1692

we cannot solve other issues until this one is fixed

@norbertschuler
Copy link
Collaborator Author

@jmiridis can we fix #1692

we cannot solve other issues until this one is fixed

Problem got fixed says @jmiridis.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants