-
Notifications
You must be signed in to change notification settings - Fork 18
Fixed One issue of Pledge events v1.2 regarding Headers #1697
Conversation
Added 3 Types of Header components 1. Header with no Animations 2. Header with Title Animation 3. Header with Title and Image Animation Removed Search bar and unneccessary spacing The Headers do not support - 1. Search 2. Share 3. Burger Menu etc These will be added soon
|
can you test if the latest commit fixed it for you |
I can earliest test this again at Monday. |
This comment has been minimized.
This comment has been minimized.
Yes, why can't we solve this with a given solution from react-native as a SafeAreaView instead of trying to fix it with an own solution? |
|
…ssue, fixed multiline text issue
I am sorry, I can not see the reason for the build failure from your screen shot. Maybe you can try clean your build or rerun the pod install with |
@harshvitra which SafeAreaView do you use? We have two different components from Check out some article about the different versions of SafeAreaView: https://medium.com/@maheshnandam/use-safeareaview-from-react-navigation-to-fix-iphone-x-design-issue-ba531a9181d |
I did this already - 'fatal error: 'UIKit/UIUserActivity.h' file not found' This is what I can read in terminal |
Probably react-native 0.6x requires at least Xcode 10.x to work and Xcode 9.x is not supported any more: facebook/react-native#25492 |
As we now use v4 of |
https://www.loom.com/share/7ad1571f4db7402aa067fa101ff39d9b @harshvitra you need to change some CSS I am not sure it's in design or something we have put that intentionally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me now (test on iPhone 5s, iPhone 6 and iPhone 11 simulator as well as Samsung Galaxy S6 Edge).
Fixes one issue from #1685
### Added 3 Types of Header components
Removed Search bar and unnecessary spacing
The Headers do not support -
etc
These shall be added soon
@sagararyal please check the Headers and animations