Skip to content
This repository has been archived by the owner on Jan 16, 2024. It is now read-only.

Fixed One issue of Pledge events v1.2 regarding Headers #1697

Merged
merged 12 commits into from
Dec 11, 2019

Conversation

harshvitra
Copy link
Collaborator

20191204_030213

Fixes one issue from #1685

### Added 3 Types of Header components

  1. Header with no Animations
  2. Header with Title Animation
  3. Header with Title and Image Animation

Removed Search bar and unnecessary spacing

The Headers do not support -

  1. Search
  2. Share
  3. Burger Menu
    etc

These shall be added soon

@sagararyal please check the Headers and animations

harshvitra1412 and others added 4 commits December 4, 2019 02:56
Added 3 Types of Header components
1. Header with no Animations
2. Header with Title Animation
3. Header with Title and Image Animation

Removed Search bar and unneccessary spacing

The Headers do not support -
1. Search
2. Share
3. Burger Menu
etc

These will be added soon
@norbertschuler
Copy link
Collaborator

norbertschuler commented Dec 6, 2019

  • On an iPhone X simulator the header does not work (arrow is not clickable) as the header does not check the top safety area - I assume that's because we don't regard it at
    forceInset={{ top: 'never', bottom: 'always' }}
    - but please do not change that as otherwise our current header would not work correctly. Maybe you can add an additional <SafeAreaView> for you own header:

Simulator Screen Shot - iPhone 11 - 2019-12-06 at 13 41 56

Simulator Screen Shot - iPhone 11 - 2019-12-06 at 13 42 05

@harshvitra
Copy link
Collaborator Author

  • On an iPhone X simulator the header does not work (arrow is not clickable) as the header does not check the top safety area - I assume that's because we don't regard it at

can you test if the latest commit fixed it for you

@norbertschuler
Copy link
Collaborator

can you test if the latest commit fixed it for you

I can earliest test this again at Monday.

@sagararyal
Copy link
Member

@norbertschuler

This comment has been minimized.

@norbertschuler
Copy link
Collaborator

norbertschuler commented Dec 9, 2019

@harshvitra https://facebook.github.io/react-native/docs/safeareaview

Yes, why can't we solve this with a given solution from react-native as a SafeAreaView instead of trying to fix it with an own solution?

@norbertschuler
Copy link
Collaborator

norbertschuler commented Dec 9, 2019

  • On an iPhone X simulator the header does not work (arrow is not clickable) as the header does not check the top safety area - I assume that's because we don't regard it at

can you test if the latest commit fixed it for you

  • I did a new test with my iPhone X simulator with the given fix, but it still does not work:

Simulator Screen Shot - iPhone 11 - 2019-12-09 at 09 07 48

@harshvitra
Copy link
Collaborator Author

Yes, why can't we solve this with a given solution from react-native as a SafeAreaView instead of trying to fix it with an own solution?

I've added SafeAreaView

But cant get iphone simulator to build -
Screen Shot 2019-12-09 at 11 20 00 PM

@norbertschuler
Copy link
Collaborator

I've added SafeAreaView
But cant get iphone simulator to build

I am sorry, I can not see the reason for the build failure from your screen shot. Maybe you can try clean your build or rerun the pod install with pod install in your ios folder.

@norbertschuler
Copy link
Collaborator

norbertschuler commented Dec 9, 2019

@harshvitra which SafeAreaView do you use? We have two different components from react-navigation and react-native used within our sources (don't ask me why ;-)):

Bildschirmfoto 2019-12-09 um 20 25 25

Check out some article about the different versions of SafeAreaView: https://medium.com/@maheshnandam/use-safeareaview-from-react-navigation-to-fix-iphone-x-design-issue-ba531a9181d

@harshvitra
Copy link
Collaborator Author

I am sorry, I can not see the reason for the build failure from your screen shot. Maybe you can try clean your build or rerun the pod install with pod install in your ios folder.

I did this already -

'fatal error: 'UIKit/UIUserActivity.h' file not found'

This is what I can read in terminal

@norbertschuler
Copy link
Collaborator

I am sorry, I can not see the reason for the build failure from your screen shot. Maybe you can try clean your build or rerun the pod install with pod install in your ios folder.

I did this already -

'fatal error: 'UIKit/UIUserActivity.h' file not found'

This is what I can read in terminal

Probably react-native 0.6x requires at least Xcode 10.x to work and Xcode 9.x is not supported any more: facebook/react-native#25492

@norbertschuler
Copy link
Collaborator

Check out some article about the different versions of SafeAreaView: https://medium.com/@maheshnandam/use-safeareaview-from-react-navigation-to-fix-iphone-x-design-issue-ba531a9181d

As we now use v4 of react-navigation I think we have case 1 and should only more use import {SafeAreaView} from 'react-navigation'; without forceInset and with a proper headerStyle.

@sanjayradadiya
Copy link
Contributor

https://www.loom.com/share/7ad1571f4db7402aa067fa101ff39d9b

@harshvitra you need to change some CSS
There is lot's of white space

I am not sure it's in design or something we have put that intentionally

Copy link
Collaborator

@norbertschuler norbertschuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me now (test on iPhone 5s, iPhone 6 and iPhone 11 simulator as well as Samsung Galaxy S6 Edge).

@norbertschuler norbertschuler merged commit 4200723 into develop Dec 11, 2019
@norbertschuler norbertschuler deleted the feature/pledgeventsFixes branch December 11, 2019 08:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants