Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxies for neoclassical transport of energetic ions #1229

Closed
wants to merge 48 commits into from

Conversation

gretahibbard
Copy link
Collaborator

@gretahibbard gretahibbard commented Aug 28, 2024

Adding proxies for neoclassical transport from Velasco's "A model for the fast evaluation of prompt losses of
energetic ions in stellarators" https://doi.org/10.1088/1741-4326/ac2994

  • Gamma_c [ eq. 16 ]
  • Gamma_delta [ eq. 19 ]
  • and Gamma_alpha [ eq. 25 ]

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@rahulgaur104 rahulgaur104 marked this pull request as draft August 28, 2024 14:04
@YigitElma
Copy link
Collaborator

YigitElma commented Aug 28, 2024

I know this is still a draft and you will probably make many changes but I want to make some kind suggestions,

  • You can install pre-commit for automatic checks when you commit such that you don't get comments from github-actions https://github.com/PlasmaControl/DESC/blob/master/CONTRIBUTING.rst#python-styleguide
  • On VS Code, there is black formatter plugin which will automatically format a file when you save it, I find this very usefull
  • to exclude the files (you use for testing and debugging purposes) from git version control, you can update your .git/info/exclude file which is a local .gitignore file (because we don't want to add a bunch of files to the main .gitignore)
  • if you run a jupyter notebook on tutorials folder, even if you don't make actual code changes, some device info part of the file will change which cause git to track those changes. I recommend don't commit those changes (in VS Code you can revert those files to the original format 'before committing') because in future it may cause merge conflicts which is very cumbersome to resolve for notebooks. If you already committed the changes, you can copy/paste the files from master branch

These are general suggestions for devs

@rahulgaur104 rahulgaur104 changed the title Gh/gamma c Proxies for neoclassical transport of energetic ions Aug 28, 2024
@unalmis unalmis mentioned this pull request Aug 29, 2024
3 tasks
unalmis added a commit that referenced this pull request Sep 3, 2024
This PR adds functionality to compute bounce averages in DESC

- [x] Differentiable algorithm to compute bounce points and integrals.
- [x] Works with any numerical quadrature
- [x] Fixed bugs with numpy compatibility.

Related
- #1003 
- #1042 
- #1229 
- #1196
"bool : Whether to adaptively integrate over the velocity coordinate. "
"If true, then num_pitch specifies an upper bound on the maximum number "
"of function evaluations."
),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add thresh (or I'd prefer the full name threshold actually) as a keyword arg here, that way when this is computed it can be specified by the user. see for example helicity kwarg in the QS quantities (

helicity="tuple: Type of quasisymmetry, (M,N). Default (1,0)",
)

name="Gamma_d Velasco",
label=(
# Γ_c = π/(8√2) ∫dλ 〈 ∑ⱼ [v τ γ_c²]ⱼ 〉
"\\Gamma_c = \\frac{\\pi}{8 \\sqrt{2}} "
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update math label

@unalmis unalmis added the Bug fix Something was fixed label Nov 24, 2024
@unalmis unalmis linked an issue Nov 24, 2024 that may be closed by this pull request
@dpanici
Copy link
Collaborator

dpanici commented Nov 26, 2024

There are some changes in the files which are confusing to me, should go through and clean this up as well (for example, the basic equilibrium notebook is deleted, that should not be deleted)

@unalmis unalmis removed the Bug fix Something was fixed label Dec 11, 2024
Base automatically changed from Gamma_c to master December 13, 2024 17:41
@unalmis unalmis linked an issue Dec 13, 2024 that may be closed by this pull request
@gretahibbard gretahibbard deleted the gh/Gamma_c branch January 21, 2025 17:30
@gretahibbard gretahibbard restored the gh/Gamma_c branch January 21, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add particle confinement proxies JIT Error encountered due to jax, hashing, and constants
5 participants