Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove zip strict statement, always attempt broadcast when setting coilset current #1611

Merged
merged 2 commits into from
Mar 1, 2025

Conversation

dpanici
Copy link
Collaborator

@dpanici dpanici commented Feb 28, 2025

Python 3.9 does not support strict=True for zip, so this change has the same check but makes strict=True unneecessary, as now it will always call broadcast_to

@dpanici dpanici added the easy Short and simple to code or review label Feb 28, 2025
@dpanici dpanici requested review from a team, rahulgaur104, f0uriest, ddudt, sinaatalay, unalmis and YigitElma and removed request for a team February 28, 2025 22:39
Copy link
Contributor

github-actions bot commented Feb 28, 2025

|             benchmark_name             |         dt(%)          |         dt(s)          |        t_new(s)        |        t_old(s)        | 
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
 test_build_transform_fft_lowres         |     -0.48 +/- 4.24     | -3.13e-03 +/- 2.73e-02 |  6.42e-01 +/- 1.8e-02  |  6.45e-01 +/- 2.1e-02  |
 test_equilibrium_init_medres            |     -1.37 +/- 2.75     | -6.22e-02 +/- 1.25e-01 |  4.47e+00 +/- 6.9e-02  |  4.53e+00 +/- 1.0e-01  |
 test_equilibrium_init_highres           |     -0.39 +/- 1.16     | -2.13e-02 +/- 6.32e-02 |  5.44e+00 +/- 4.6e-02  |  5.46e+00 +/- 4.4e-02  |
 test_objective_compile_dshape_current   |     +1.42 +/- 4.75     | +6.09e-02 +/- 2.04e-01 |  4.35e+00 +/- 1.4e-01  |  4.29e+00 +/- 1.5e-01  |
 test_objective_compute_dshape_current   |     -0.94 +/- 5.90     | -5.20e-05 +/- 3.27e-04 |  5.49e-03 +/- 1.7e-04  |  5.54e-03 +/- 2.8e-04  |
 test_objective_jac_dshape_current       |     +0.31 +/- 6.65     | +1.35e-04 +/- 2.89e-03 |  4.35e-02 +/- 2.2e-03  |  4.34e-02 +/- 1.8e-03  |
 test_perturb_2                          |     +0.82 +/- 2.22     | +1.72e-01 +/- 4.65e-01 |  2.11e+01 +/- 2.8e-01  |  2.09e+01 +/- 3.7e-01  |
 test_proximal_jac_atf_with_eq_update    |     +0.13 +/- 1.14     | +2.16e-02 +/- 1.95e-01 |  1.72e+01 +/- 1.8e-01  |  1.72e+01 +/- 7.5e-02  |
 test_proximal_freeb_jac                 |     +0.87 +/- 1.94     | +6.26e-02 +/- 1.40e-01 |  7.28e+00 +/- 1.3e-01  |  7.22e+00 +/- 4.8e-02  |
 test_solve_fixed_iter_compiled          |     -0.08 +/- 1.16     | -1.70e-02 +/- 2.47e-01 |  2.13e+01 +/- 1.8e-01  |  2.13e+01 +/- 1.7e-01  |
 test_LinearConstraintProjection_build   |     -1.52 +/- 3.04     | -1.76e-01 +/- 3.51e-01 |  1.14e+01 +/- 2.4e-01  |  1.15e+01 +/- 2.5e-01  |
 test_objective_compute_ripple_spline    |     -1.07 +/- 3.84     | -3.77e-03 +/- 1.36e-02 |  3.50e-01 +/- 4.3e-03  |  3.54e-01 +/- 1.3e-02  |
 test_objective_grad_ripple_spline       |     +0.79 +/- 2.18     | +1.13e-02 +/- 3.10e-02 |  1.43e+00 +/- 1.6e-02  |  1.42e+00 +/- 2.6e-02  |
 test_build_transform_fft_midres         |     -1.63 +/- 7.28     | -1.12e-02 +/- 5.00e-02 |  6.75e-01 +/- 3.0e-02  |  6.86e-01 +/- 4.0e-02  |
 test_build_transform_fft_highres        |     -3.32 +/- 5.94     | -3.25e-02 +/- 5.81e-02 |  9.44e-01 +/- 4.6e-02  |  9.77e-01 +/- 3.5e-02  |
 test_equilibrium_init_lowres            |     +0.20 +/- 5.17     | +8.73e-03 +/- 2.25e-01 |  4.36e+00 +/- 1.4e-01  |  4.35e+00 +/- 1.7e-01  |
 test_objective_compile_atf              |     -0.06 +/- 3.57     | -5.42e-03 +/- 3.10e-01 |  8.67e+00 +/- 1.6e-01  |  8.68e+00 +/- 2.6e-01  |
 test_objective_compute_atf              |     -1.23 +/- 7.69     | -2.11e-04 +/- 1.32e-03 |  1.70e-02 +/- 1.2e-03  |  1.72e-02 +/- 6.3e-04  |
 test_objective_jac_atf                  |     -1.03 +/- 2.23     | -2.05e-02 +/- 4.45e-02 |  1.98e+00 +/- 3.8e-02  |  2.00e+00 +/- 2.3e-02  |
 test_perturb_1                          |     -1.50 +/- 2.28     | -2.40e-01 +/- 3.67e-01 |  1.58e+01 +/- 1.3e-01  |  1.61e+01 +/- 3.4e-01  |
 test_proximal_jac_atf                   |     +0.24 +/- 1.30     | +1.91e-02 +/- 1.06e-01 |  8.16e+00 +/- 6.9e-02  |  8.14e+00 +/- 8.1e-02  |
 test_proximal_freeb_compute             |     -0.09 +/- 1.81     | -1.98e-04 +/- 3.98e-03 |  2.19e-01 +/- 3.2e-03  |  2.19e-01 +/- 2.4e-03  |
 test_solve_fixed_iter                   |     +0.02 +/- 2.24     | +8.40e-03 +/- 7.60e-01 |  3.40e+01 +/- 4.6e-01  |  3.40e+01 +/- 6.0e-01  |
 test_objective_compute_ripple           |     -1.11 +/- 1.40     | -7.85e-03 +/- 9.91e-03 |  7.01e-01 +/- 5.2e-03  |  7.09e-01 +/- 8.4e-03  |
 test_objective_grad_ripple              |     +0.50 +/- 1.96     | +1.33e-02 +/- 5.22e-02 |  2.68e+00 +/- 4.1e-02  |  2.66e+00 +/- 3.2e-02  |

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.70%. Comparing base (ad26bcd) to head (48c9f0d).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1611   +/-   ##
=======================================
  Coverage   95.70%   95.70%           
=======================================
  Files         101      101           
  Lines       26349    26348    -1     
=======================================
  Hits        25216    25216           
+ Misses       1133     1132    -1     
Files with missing lines Coverage Δ
desc/coils.py 98.02% <100.00%> (-0.01%) ⬇️

... and 2 files with indirect coverage changes

@dpanici dpanici added the skip_changelog No need to update changelog on this PR label Mar 1, 2025
@dpanici dpanici merged commit 22c1e46 into master Mar 1, 2025
27 of 28 checks passed
@dpanici dpanici deleted the dp/hotfix branch March 1, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy Short and simple to code or review skip_changelog No need to update changelog on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants