Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nfp #1613

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

nfp #1613

wants to merge 1 commit into from

Conversation

unalmis
Copy link
Collaborator

@unalmis unalmis commented Mar 1, 2025

No description provided.

@unalmis unalmis added question Further information is requested easy Short and simple to code or review labels Mar 1, 2025
@unalmis unalmis requested a review from dpanici March 1, 2025 16:09
if source_grid is not None:
assert (
source_grid.NFP == self.NFP
), f"{source_grid.NFP} does not equal {self.NFP}"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fails. Should it?

Copy link
Contributor

github-actions bot commented Mar 1, 2025

|             benchmark_name             |         dt(%)          |         dt(s)          |        t_new(s)        |        t_old(s)        | 
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
 test_build_transform_fft_lowres         |     +3.49 +/- 6.07     | +2.11e-02 +/- 3.68e-02 |  6.27e-01 +/- 3.6e-02  |  6.06e-01 +/- 8.5e-03  |
 test_equilibrium_init_medres            |     +0.01 +/- 1.63     | +3.86e-04 +/- 6.94e-02 |  4.25e+00 +/- 5.3e-02  |  4.25e+00 +/- 4.4e-02  |
 test_equilibrium_init_highres           |     +0.57 +/- 2.34     | +2.99e-02 +/- 1.22e-01 |  5.24e+00 +/- 3.5e-02  |  5.21e+00 +/- 1.2e-01  |
 test_objective_compile_dshape_current   |     +0.20 +/- 4.65     | +8.38e-03 +/- 1.94e-01 |  4.18e+00 +/- 1.4e-01  |  4.17e+00 +/- 1.3e-01  |
 test_objective_compute_dshape_current   |     +1.31 +/- 1.25     | +7.08e-05 +/- 6.75e-05 |  5.49e-03 +/- 5.3e-05  |  5.42e-03 +/- 4.2e-05  |
 test_objective_jac_dshape_current       |     -0.71 +/- 6.78     | -3.07e-04 +/- 2.93e-03 |  4.29e-02 +/- 2.1e-03  |  4.33e-02 +/- 2.0e-03  |
 test_perturb_2                          |     +0.57 +/- 1.59     | +1.17e-01 +/- 3.23e-01 |  2.05e+01 +/- 1.9e-01  |  2.04e+01 +/- 2.6e-01  |
 test_proximal_jac_atf_with_eq_update    |     +0.18 +/- 0.82     | +3.08e-02 +/- 1.38e-01 |  1.70e+01 +/- 9.3e-02  |  1.69e+01 +/- 1.0e-01  |
 test_proximal_freeb_jac                 |     -0.64 +/- 1.90     | -3.20e-02 +/- 9.45e-02 |  4.95e+00 +/- 7.0e-02  |  4.98e+00 +/- 6.4e-02  |
 test_solve_fixed_iter_compiled          |     -0.45 +/- 1.42     | -9.49e-02 +/- 2.97e-01 |  2.09e+01 +/- 2.8e-01  |  2.10e+01 +/- 9.5e-02  |
 test_LinearConstraintProjection_build   |     +0.53 +/- 2.30     | +5.87e-02 +/- 2.57e-01 |  1.12e+01 +/- 1.6e-01  |  1.12e+01 +/- 2.0e-01  |
 test_objective_compute_ripple_spline    |     -1.04 +/- 2.26     | -3.66e-03 +/- 7.99e-03 |  3.49e-01 +/- 2.9e-03  |  3.53e-01 +/- 7.4e-03  |
 test_objective_grad_ripple_spline       |     -0.50 +/- 1.91     | -7.05e-03 +/- 2.71e-02 |  1.41e+00 +/- 2.2e-02  |  1.42e+00 +/- 1.6e-02  |
 test_build_transform_fft_midres         |     +5.21 +/- 9.00     | +3.37e-02 +/- 5.82e-02 |  6.80e-01 +/- 3.7e-02  |  6.47e-01 +/- 4.5e-02  |
 test_build_transform_fft_highres        |     +3.28 +/- 5.86     | +3.06e-02 +/- 5.46e-02 |  9.62e-01 +/- 4.2e-02  |  9.32e-01 +/- 3.5e-02  |
 test_equilibrium_init_lowres            |     +6.19 +/- 3.76     | +2.45e-01 +/- 1.49e-01 |  4.20e+00 +/- 1.2e-01  |  3.95e+00 +/- 8.7e-02  |
 test_objective_compile_atf              |     +2.10 +/- 2.84     | +1.74e-01 +/- 2.35e-01 |  8.44e+00 +/- 1.0e-01  |  8.27e+00 +/- 2.1e-01  |
 test_objective_compute_atf              |     +1.38 +/- 7.49     | +2.27e-04 +/- 1.24e-03 |  1.67e-02 +/- 1.2e-03  |  1.65e-02 +/- 3.7e-04  |
 test_objective_jac_atf                  |     -0.36 +/- 2.80     | -7.00e-03 +/- 5.49e-02 |  1.95e+00 +/- 2.4e-02  |  1.96e+00 +/- 4.9e-02  |
 test_perturb_1                          |     +2.82 +/- 3.91     | +4.22e-01 +/- 5.85e-01 |  1.54e+01 +/- 5.4e-01  |  1.50e+01 +/- 2.3e-01  |
 test_proximal_jac_atf                   |     -0.65 +/- 1.75     | -5.25e-02 +/- 1.41e-01 |  8.00e+00 +/- 7.1e-02  |  8.05e+00 +/- 1.2e-01  |
 test_proximal_freeb_compute             |     +3.76 +/- 1.63     | +7.05e-03 +/- 3.06e-03 |  1.94e-01 +/- 1.6e-03  |  1.87e-01 +/- 2.6e-03  |
 test_solve_fixed_iter                   |     -0.25 +/- 2.71     | -8.29e-02 +/- 8.86e-01 |  3.26e+01 +/- 7.1e-01  |  3.27e+01 +/- 5.3e-01  |
 test_objective_compute_ripple           |     +0.62 +/- 1.93     | +4.28e-03 +/- 1.34e-02 |  6.95e-01 +/- 8.6e-03  |  6.90e-01 +/- 1.0e-02  |
 test_objective_grad_ripple              |     +0.21 +/- 1.79     | +5.60e-03 +/- 4.70e-02 |  2.64e+00 +/- 3.1e-02  |  2.63e+00 +/- 3.6e-02  |

@unalmis unalmis added easy Short and simple to code or review and removed question Further information is requested easy Short and simple to code or review labels Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy Short and simple to code or review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant