Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a class for nuclear reactions #2537

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

namurphy
Copy link
Member

[to be added later]

First part of #2535.

@github-actions github-actions bot added the plasmapy.particles Related to the plasmapy.particles subpackage label Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.71%. Comparing base (93bf7ae) to head (fca509d).

Current head fca509d differs from pull request most recent head 7049264

Please upload reports for the commit 7049264 to get more accurate results.

Files with missing lines Patch % Lines
plasmapy/particles/interactions.py 96.42% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2537      +/-   ##
==========================================
+ Coverage   95.12%   96.71%   +1.58%     
==========================================
  Files         107      105       -2     
  Lines        9626     9395     -231     
  Branches     2230        0    -2230     
==========================================
- Hits         9157     9086      -71     
- Misses        280      309      +29     
+ Partials      189        0     -189     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@namurphy namurphy added this to the v2024.5.0 milestone Apr 9, 2024
return total_charge


class AbstractParticleInteraction(ABC):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the ABC private while we are figuring out the interface?

@github-actions github-actions bot added the python Pull requests that update Python code label May 19, 2024
@namurphy namurphy modified the milestones: v2024.5.0, v2024.9.0 Jul 19, 2024
@namurphy namurphy removed this from the v2024.10.0 milestone Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plasmapy.particles Related to the plasmapy.particles subpackage python Pull requests that update Python code status: in progress testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant