feat(external_messaging): Adds external messaging resolver #961
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Introduces concept of external messaging handlers. By using the path of
messages/external/
, we can leverage the same messaging features, but they will be registered viachrome.runtime.onMessageExternal.addListener
instead ofchrome.runtime.onMessage.addListener
.This fixes an issue currently where all message handlers are being registered as internal AND external handlers, which can be unsafe.
You can either set up a message handler in
background/messages/my-handler.ts
, orbackground/messages/external/my-external-handler.ts
. If you want a message handler to work in both contexts, symlink itln -s background/messages/my-safe-handler.ts background/messages/external/my-safe-handler.ts
.Code of Conduct
Contacts
If your PR is accepted, we will award you with the
Contributor
role on Discord server.To join the server, visit: https://www.plasmo.com/s/d