Add support for Unreal Engine 5.5 #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SRombautsU
commented
Oct 16, 2024
•
SRombautsU
commented
- New APIS in UE5.5 for RemoveAt(0, EAllowShrinking::No) and MidInline(3, x, EAllowShrinking::No);
- Note: change taken from upstream in-engine plugin so we don't diverge more than needed
- Fix UE5.5 missing definitions of ENGINE_MAJOR_VERSION
- Add 2 missing #include "Runtime/Launch/Resources/Version.h"
- Move 2 #if ENGINE_MAJOR_VERSION == 5 after the include of the header, that in turn includes the needed "Version.h"
- Fix unit test compilation with UE5.5 Replace the bitmask EAutomationTestFlags::ApplicationContextMask that was removed from the Engine with a more precise EAutomationTestFlags::EditorContext | EAutomationTestFlags::CommandletContext
…3, x, EAllowShrinking::No);
Add 2 missing #include "Runtime/Launch/Resources/Version.h"
Move 2 #if ENGINE_MAJOR_VERSION == 5 after the include of the header, that in turn includes the needed "Version.h"
Replace the bitmask EAutomationTestFlags::ApplicationContextMask that was removed from the Engine (note: not deprecated, just removed) with a more precise EAutomationTestFlags::EditorContext | EAutomationTestFlags::CommandletContext (note: we don't care for execution of the unit tests in the client build or the server build as the plugin is Editor Only)
juliomaqueda
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.