Implement shelve status: listing shelves and their content #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SRombautsU
force-pushed
the
1001532-shelve-status
branch
3 times, most recently
from
d2c66ae to
e7935fb
Compare
Look for shelves with comments starting like "ChangelistXXX: " and matching an existing Changelist
SRombautsU
force-pushed
the
1001532-shelve-status
branch
from
e7935fb to
20ebdf4
Compare
juliomaqueda
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Look for shelves with comments starting like "ChangelistXXX: " and matching an existing Changelist
Note: at this stage, this will show in UI shelves created manually, but there is not a single "shelve"/"unshelve"/"delete" operation implemented yet.
In practice, it means that we can safely merge that as it won't be visible to the user just yet.