Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the parser of status warning message so that the perf tips is readable to the end user #75

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

SRombautsU
Copy link

@SRombautsU SRombautsU commented Apr 5, 2023

Instead of a duplicated and convoluted message mostly unreadable

Warning: Unknown file status 'Finding changed files took too long. Perf tips: [...]' (in line 'Finding changed files took too long. Perf tips: [...]')

the log now directly displays the warning from cm:

Warning: Unknown file status 'Finding changed files took too long. Perf tips: https://www.plasticscm.com/download/help/statusperfhintschanged

…warning is readable to the end user

Instead of a duplicated and convoluted message mostly unreadable:
"Warning: Unknown file status 'Finding changed files took too long. Perf tips: [...]' (in line 'Finding changed files took too long. Perf tips: [...]')"
the log now directly display the warning from cm:
"Warning: Unknown file status 'Finding changed files took too long. Perf tips: https://www.plasticscm.com/download/help/statusperfhintschanged"
@SRombautsU SRombautsU added the bug label Apr 5, 2023
@SRombautsU SRombautsU self-assigned this Apr 5, 2023
@SRombautsU SRombautsU changed the title Fix the parser of files status warning message so that the perf tips warning is readable to the end user Fix the parser of status warning message so that the perf tips is readable to the end user Apr 5, 2023
@juliomaqueda juliomaqueda merged commit 9eeae76 into master Apr 12, 2023
@juliomaqueda juliomaqueda deleted the 1003084-fix-unknown-file-status-warning branch April 12, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants