Add support for capturing the output of Processes #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmayspark
commented
Aug 13, 2022
kerdrek
requested changes
Aug 18, 2022
|
Do you have an example text output for a run? |
|
@yegarci updated the PR description - check out the link! |
|
Sorry, I mean do you have an example output where the new stderror and stdout streams are written? |
KalonJ-MSFT
reviewed
Aug 19, 2022
KalonJ-MSFT
reviewed
Aug 19, 2022
yegarci
approved these changes
Aug 22, 2022
kerdrek
approved these changes
Aug 23, 2022
added more validation in ProcessOutputLoger based on the review.
… / logging added more unit tests.
emmayspark
force-pushed
the
emmap/CaptureLogsProcess
branch
from
f6ec94d to
a985f5f
Compare
brianwp3000
requested changes
Aug 23, 2022
Summary: tested code with streamWriter with sample console app to one callback functions is availiable at once and it worked fine. However, multiple filewriter instances will be created not in Main Thread. By using FileWriter.Synchonized(), we can make it thread safe.
yegarci
approved these changes
Aug 29, 2022
brianwp3000
requested changes
Aug 29, 2022
brianwp3000
reviewed
Aug 29, 2022
removed default value in interface
brianwp3000
approved these changes
Aug 29, 2022
brianwp3000
added a commit
that referenced
this pull request
Sep 1, 2022
This reverts commit ebe538b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code supports capturing stderr and stdout logs of Processes.
When Process object is created, Start Information is configured with event handlers to subscribe to events and redirect streams of standard output/errors to the event handlers. Whenever events are raised to event handlers, it writes them to the PF_ConsoleLog.txt until process is terminated or error is captured.
Sample Output For Windows Process:
PF_ConsoleLogs.txt
Sample Output For Linux Process:
PF_ConsoleLogs(Linux).txt