Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run "check-if-install-files-are-modified" in a separate step #341

Closed
dgkanatsios opened this issue Jul 25, 2022 · 2 comments
Closed

Run "check-if-install-files-are-modified" in a separate step #341

dgkanatsios opened this issue Jul 25, 2022 · 2 comments
Labels
area/build-tools Dev tooling that is in the build directory

Comments

@dgkanatsios
Copy link
Collaborator

We have a step in our CI pipeline that checks if the install files are modified. This is expected to fail when we generate new version (like https://github.com/PlayFab/thundernetes/runs/7503593614?check_suite_focus=true) but this should not prevent the rest of CI tests to run. For this, we should create a separate workflow that runs the "check if installer files are modified" step.
@dgkanatsios dgkanatsios changed the title Run "check-if-install-m Run "check-if-install-files-are-modified" in a separate step Jul 25, 2022
@dgkanatsios dgkanatsios added the area/build-tools Dev tooling that is in the build directory label Jul 25, 2022
@dgkanatsios
Copy link
Collaborator Author

#369 will split the main pipeline into two.

@dgkanatsios
Copy link
Collaborator Author

Closing this as we kinda implemented it in #369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/build-tools Dev tooling that is in the build directory
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dgkanatsios