Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

various refactorings #369

Merged
merged 5 commits into from
Aug 8, 2022
Merged

various refactorings #369

merged 5 commits into from
Aug 8, 2022

Conversation

dgkanatsios
Copy link
Collaborator

@dgkanatsios dgkanatsios commented Aug 6, 2022 •
edited
Loading

Various refactorings in the codebase.
Specifically:

  • refactored expectations related code out of the GameServerBuild reconciler
  • created a test for expectations related code
  • refactored controller's initial configuration, using a struct to encapsulate all customizable options coming from environment variables
  • split the "CI" pipeline into two, a "unit tests" and an "end to end tests" one
  • various comment corrections here and there

@dgkanatsios dgkanatsios force-pushed the refactorings branch 12 times, most recently from 8ed21dd to be6550c Compare August 6, 2022 15:07
@dgkanatsios dgkanatsios mentioned this pull request Aug 6, 2022
Closed
@dgkanatsios dgkanatsios force-pushed the refactorings branch 2 times, most recently from f45affe to f650e3a Compare August 6, 2022 17:34
@dgkanatsios dgkanatsios force-pushed the refactorings branch 5 times, most recently from d5369c1 to 5a5a245 Compare August 7, 2022 20:59
@dgkanatsios dgkanatsios changed the title [WIP] various refactorings various refactorings Aug 8, 2022
@dgkanatsios dgkanatsios marked this pull request as ready for review August 8, 2022 07:55
@dgkanatsios dgkanatsios force-pushed the refactorings branch 3 times, most recently from 271096b to 0002bca Compare August 8, 2022 11:19
@dgkanatsios dgkanatsios force-pushed the refactorings branch 2 times, most recently from d22495a to a559871 Compare August 8, 2022 15:55
@dgkanatsios dgkanatsios merged commit 2a7e2a8 into main Aug 8, 2022
@dgkanatsios dgkanatsios deleted the refactorings branch August 8, 2022 15:57
This was referenced Aug 8, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javier-op javier-op javier-op approved these changes

Assignees
No one assigned
Labels
code-quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgkanatsios @javier-op