Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganizing Project Layout #119

Merged
merged 38 commits into from
Dec 24, 2021
Merged

Conversation

khaines
Copy link
Collaborator

@khaines khaines commented Dec 20, 2021

The Focus of this PR is to reorganize the project files closer to guidance found here: https://github.com/golang-standards/project-layout

It is not a perfect shift, but this should be the largest move of files, so I wanted to get the PR in as it is.

  • Go is now set to 1.17
  • Combines project to a single go module, vs many.
  • The executable packages (containing a main.go file) have been moved under the /cmd directory.
  • Referenced libraries, have been moved to the /pkg directory. There is code in the executable packages, which can be placed in a sharable reference package; these will be moved in a future PR.
  • MAKEFILE has been updated to automatically detect the presence of a Dockerfile at build time and create the corresponding container, removing the need to hardcode docker build commands for each one.
  • Moved common build steps to a parent "build" container, which will prep the space for each application to be build and avoids duplication of copying common files to a container.

Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
@dgkanatsios dgkanatsios self-requested a review December 21, 2021 07:13
@dgkanatsios
Copy link
Collaborator

Great work, thanks! I'll post here with findings :) Repo has a VS Code workspace, which IIRC was needed since there were multiple Go apps. Do we need it now that we have a single go.mod file?

Makefile Show resolved Hide resolved
Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
…new paths

Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
build-env/Dockerfile Outdated Show resolved Hide resolved
Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
…stall files

Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
Makefile Outdated Show resolved Hide resolved
Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
Makefile Outdated Show resolved Hide resolved
Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
@khaines khaines merged commit 696d449 into PlayFab:master Dec 24, 2021
@dgkanatsios dgkanatsios mentioned this pull request Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants