Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crashes test #147

Merged
merged 1 commit into from
Jan 31, 2022
Merged

fix crashes test #147

merged 1 commit into from
Jan 31, 2022

Conversation

dgkanatsios
Copy link
Collaborator

A recent PR (#143) seems to have made the controller react different to multiple crashes occurring at the same time introducing a transient issue https://github.com/PlayFab/thundernetes/runs/4903482916?check_suite_focus=true

This PR makes the test suite more flexible by allowing more than expected crashes to be valid.

@dgkanatsios dgkanatsios added the area/tests Make sure things don't break, unit tests. label Jan 22, 2022
@dgkanatsios dgkanatsios added this to the 0.3.0 milestone Jan 22, 2022
@dgkanatsios dgkanatsios marked this pull request as ready for review January 24, 2022 23:23
@dgkanatsios dgkanatsios merged commit 6aad358 into master Jan 31, 2022
@dgkanatsios dgkanatsios deleted the fixcrashestest branch January 31, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests Make sure things don't break, unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants