unblocking unhealthy GameServerBuild #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgkanatsios
force-pushed
the
unhealthy
branch
from
3892d00
to
d6c7600
Compare
khaines
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #155
Currently, once the GameServerBuild becomes unhealthy, no other operation (controller reconciliation) will take place on the GameServerBuild. This can be a blocker on some scenarios where we want this to continue. We need to think of a better overall solution, but for the time being this PR allows the user to increase the value of the GameServerBuild.Spec.CrashesToMarkUnhealthy so the controller will continue to perform reconciliations on it.