refactoring GameServerDetails and InitialPlayers #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgkanatsios
force-pushed
the
initialplayers
branch
from
188b016
to
62d7aa2
Compare
dgkanatsios
force-pushed
the
initialplayers
branch
3 times, most recently
from
56c14b0
to
5a5e4cf
Compare
javier-op
reviewed
Apr 18, 2022
dgkanatsios
force-pushed
the
initialplayers
branch
from
5a5e4cf
to
6c07ea9
Compare
javier-op
approved these changes
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #226
This PR moves the InitialPlayers string array back to GameServer CR, check #226 for more details.