making CrashesToMarkUnhealthy optional #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgkanatsios
force-pushed
the
crashes
branch
5 times, most recently
from
5d06129
to
0f30bd1
Compare
javier-op
reviewed
Jul 11, 2022
| @@ -81,7 +81,6 @@ spec: | |||
| type: object | |||
| type: array | |||
| crashesToMarkUnhealthy: | |||
| default: 5 | |||
There was a problem hiding this comment.
By removing this, the default value is nil now right?
javier-op
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #215
This PR makes the CrashesToMarkUnhealthy field optional, so that a GameServerBuild will continue scaling operations even if the GameServers keep crashing.
We need to update documentation to clarify that there is no default anymore.