version 0.0.2.0 #38
Merged
version 0.0.2.0 #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgkanatsios
commented
Oct 17, 2021
khaines
reviewed
Oct 19, 2021
| #!/bin/bash |
There was a problem hiding this comment.
I would like to offer the suggestion that we follow symver conventions for numbering.
Along that line, if we are adding new functionality, we should be at version 0.1.0.
There was a problem hiding this comment.
This can also be something we chat about before adopting it as well.
There was a problem hiding this comment.
yeah, I was thinking about it as well, thanks for bringing this up. When we do the next update, we can do 0.1.0. Thanks!
khaines
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some recent PRs (e.g. #31) altered some thundernetes functionality so we should release a new version. This PR modifies the
.versionsfile with the new versions plus fixes the Makefile generation that till recently worked on my machine. As soon as this PR is merged, we should run the Publish Container Images workflow to generate the new container images, or else the installation scripts would break.