Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameServer API #91

Merged
merged 1 commit into from
Dec 3, 2021
Merged

GameServer API #91

merged 1 commit into from
Dec 3, 2021

Conversation

dgkanatsios
Copy link
Collaborator

@dgkanatsios dgkanatsios commented Nov 23, 2021

partially fixes #79

This PR introduces a new Go module to the project, responsible for providing an API surface for people to interact with thundernetes cluster objects (GameServerBuild,GameServer,GameServerDetail). It contains code and unit tests. A follow-up PR will include end to end tests plus container image generation.

Parts of the docs/comments/code refer to the allocation API service as "API service". This PR refactors it and renames it to "allocation API service" so there is a clear distinction between the two.

@dgkanatsios dgkanatsios force-pushed the gameserverapi branch 2 times, most recently from de7bbc5 to c469231 Compare November 24, 2021 19:50
@AmieDD AmieDD added the enhancement New feature or request label Dec 1, 2021
@AmieDD
Copy link
Collaborator

AmieDD commented Dec 3, 2021

image

image
Looks good.

Copy link
Collaborator

@AmieDD AmieDD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test run and the endpoint calls look fine!

@dgkanatsios dgkanatsios merged commit 7884644 into master Dec 3, 2021
@dgkanatsios dgkanatsios deleted the gameserverapi branch December 3, 2021 21:33
@AmieDD AmieDD self-assigned this Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRUD API for GameServerBuild/GameServer CRs (GameServer API)
2 participants