Security: Removal of Postgres initdb script #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Trac hardened Postgres image
jesseops
reviewed
Dec 13, 2023
Comment on lines
-75
to
-86
| #!/bin/bash | ||
|
|
||
| PGPASSWORD="$POSTGRES_PASSWORD" | ||
| PGDATABASES=('core' 'runbooks') | ||
|
|
||
| tmpl=`cat /docker-entrypoint-initdb.d/bootstrap-template.sql.txt` | ||
|
|
||
| for db in ${PGDATABASES[@]}; do | ||
| # Ugh this is ugly. Thanks Bash | ||
| eval "echo "'"'"`echo "$tmpl" | sed "s/PLACEHOLDER/${db^^}/g" -`"'"'"" | | ||
| psql -a -v ON_ERROR_STOP=1 --username $POSTGRES_USER -d $POSTGRES_USER | ||
| done |
There was a problem hiding this comment.
RIP. I lost a lot of hair to this function.
There was a problem hiding this comment.
It's still being used, just in the new container ;)
There was a problem hiding this comment.
Dang, I'm so sorry. I'd hoped you avoided this 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removal of the prior method to create and manage the postgres initdb script and initial database creation. This is being spurred by a hardening of the Postgres image.
Tasks
plextrac/postgres:versionimage reference in thedocker-compose.yml