Fixed many games not working due to unsupported characters in file name. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many SNES games, SNES manuals and NES manuals got broken when migrating to python 3.
Only the M ROM now remains for the extracted game to be playable
At least Kirby's Adventure, possibly other games, is now extracted properly with or without save data. Before this commit, it would crash if there is save data, or export a ROM with the SRAM flag OFF if there is no save data.
time.clock() was removed in 3.8, and I had to change it to decompress an snes rom from Kirby's Dream Collection
use `time.process_time()` instead of `time.clock()`
kof94 and karnovr fully extracted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.