Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jitter with orthographic camera #77

Closed
thmxv opened this issue May 24, 2024 · 3 comments
Closed

Jitter with orthographic camera #77

thmxv opened this issue May 24, 2024 · 3 comments

Comments

@thmxv
Copy link
Contributor

thmxv commented May 24, 2024

Since commit 11b0348 (pull request #76) there are jitters when in orthographic camera.

To fix this, the system set does not only need to be before TransformSystem::TransformPropagate but also before CameraUpdateSystem (I think).

@Plonq
Copy link
Owner

Plonq commented May 24, 2024

Thanks for the report. I couldn't replicate a jitter, but I did notice a subtle flicker on startup which the above change fixes.

Fix in 0.18.2

@Plonq Plonq closed this as completed May 25, 2024
@thmxv
Copy link
Contributor Author

thmxv commented May 25, 2024

Yes sorry. I did not express myself well.

The jitters are a bit random depending on system ordering and only while zooming an orthographic camera.

The "I think" came because adding the .before(CameraUpdateSystem) fixed the issue for me, but I am not certain this is the correct fix or if it only made the randomness more favorable to me.

@Plonq
Copy link
Owner

Plonq commented May 25, 2024

Yeah I assumed it was due to random system ordering :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants